[PATCH] D50289: [ELF] Don't copy STT_TLS in copy relocation
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 6 15:23:20 PDT 2018
echristo added inline comments.
================
Comment at: ELF/Relocations.cpp:468
for (const Elf_Sym &S : File.getGlobalELFSyms()) {
if (S.st_shndx == SHN_UNDEF || S.st_shndx == SHN_ABS ||
+ S.getType() == STT_TLS || S.st_value != SS.Value)
----------------
Drive by comment: It'd be great to get a comment about everything in this conditional :)
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D50289
More information about the llvm-commits
mailing list