[PATCH] D50284: [COFF, ARM64] Recognize the .hidden directive

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In https://reviews.llvm.org/D50284#1188318, @mgrang wrote:

> In https://reviews.llvm.org/D50284#1188307, @pcc wrote:
>
> > I don't think the .hidden directive is meaningful in COFF, is it?
>
>
> Yes, I don't think too. But we still need to compile hand-written assembly containing .hidden for COFF. That's why this patch simply eats up the .hidden directive without handling it in the MCWinCOFFStreamer.cpp. I did a small test and found that MSVS exports only those symbols explicitly marked as dllexport.


I don't see why we need to parse .hidden when targeting COFF, it isn't meaningful. Gas rejects it for win64:
t.s:3: Error: unknown pseudo-op: `.hidden'


Repository:
  rL LLVM

https://reviews.llvm.org/D50284