[PATCH] D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 12:30:25 PDT 2018


scott.linder updated this revision to Diff 157104.
scott.linder added a comment.
Herald added a subscriber: mgorny.

I have updated the lit test with update_llc_test_checks, updated the condition in TargetLowering to allow for the case where DemandedElts is already wide enough, and added unittests for the cases which trigger the ICE in each function. This is still dependent on my assumptions about the exact semantics of EXTRACT_SUBVECTOR being correct.


https://reviews.llvm.org/D49574

Files:
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  lib/CodeGen/SelectionDAG/TargetLowering.cpp
  test/CodeGen/AMDGPU/extract-subvector-equal-length.ll
  unittests/CodeGen/CMakeLists.txt
  unittests/CodeGen/SelectionDAGTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49574.157104.patch
Type: text/x-patch
Size: 11277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180724/90d5d080/attachment.bin>


More information about the llvm-commits mailing list