[PATCH] D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 13:18:29 PDT 2018


arsenm added a comment.

In https://reviews.llvm.org/D49574#1170244, @scott.linder wrote:

> I can update the test with update_llc_checks, but I'm not sure about testing the other functions. This test case is a minimized version of a test which happened to trigger the assert; to test the others would it be reasonable to use unit tests instead of LLVM IR?


I'm not sure it's possible with SelectionDAG. I don't think we have any other way


https://reviews.llvm.org/D49574





More information about the llvm-commits mailing list