[PATCH] D49310: [llvm-mca][BtVer2] Teach how to identify dependency-breaking idioms.

[Matt Davis via Phabricator via llvm-commits]

mattd added a comment.

This change LGTM, but you should let  a few others take a peek before landing this.



================
Comment at: include/llvm/MC/MCInstrAnalysis.h:90
 
+  /// Returns true if \param Inst is a dependency breaking instruction for the
+  /// given subtarget.
----------------
Suggestion: It might be useful to reference Agner Fog's microarchitecture.pdf 17.9 "Breaking dependence,"  similar to how you reference another part of that doc in D49196.  Although, I think your description is clearer than 17.9, but just a thought.  A reader might find other parts of 17.x useful, such as 17.8.


https://reviews.llvm.org/D49310