[PATCH] D49310: [llvm-mca][BtVer2] Teach how to identify dependency-breaking idioms.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added inline comments.


================
Comment at: include/llvm/MC/MCInstrAnalysis.h:90
 
+  /// Returns true if \param Inst is a dependency breaking instruction for the
+  /// given subtarget.
----------------
mattd wrote:
> Suggestion: It might be useful to reference Agner Fog's microarchitecture.pdf 17.9 "Breaking dependence,"  similar to how you reference another part of that doc in D49196.  Although, I think your description is clearer than 17.9, but just a thought.  A reader might find other parts of 17.x useful, such as 17.8.
Good point. I will add a reference to the Agner Fog's "microarchitecture" to the definition of `isDependencyBreaking()` in X86MCTargetDesc.cpp. I prefer to keep this comment simple if possible.


https://reviews.llvm.org/D49310