[PATCH] D48859: Make WindowsSupport.h a public header

[Michael Spencer via Phabricator via llvm-commits]

Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D48859#1151697, @zturner wrote:

> In https://reviews.llvm.org/D48859#1151696, @Bigcheese wrote:
>
> > Is there a good reason the use cases you want this for can't be added to libSupport?  I'm a bit worried about continuing to add platform specific code outside of libSupport.
>
>
> Mostly that it's quite large.  See my recent post on llvm-dev about RFC: libtrace.  I don't want to develop an entire library inside of libSupport, and something like a libtrace will unavoidably have a lot of platform specific code.  As another example, consider lldb.  There's no way to avoid a bunch of platform specific code, and it would be nice if LLVM had a solution that allowed LLDB to re-use some of LLVM's own platform specific code.


Yeah, thought that may be the reason.  LGTM, although would it be reasonable to add a comment to the header saying not to include it in another non-windows-specific header?


https://reviews.llvm.org/D48859