[PATCH] D48859: Make WindowsSupport.h a public header

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 3 20:37:03 PDT 2018


zturner added a comment.

In https://reviews.llvm.org/D48859#1151696, @Bigcheese wrote:

> Is there a good reason the use cases you want this for can't be added to libSupport?  I'm a bit worried about continuing to add platform specific code outside of libSupport.


Mostly that it's quite large.  See my recent post on llvm-dev about RFC: libtrace.  I don't want to develop an entire library inside of libSupport, and something like a libtrace will unavoidably have a lot of platform specific code.  As another example, consider lldb.  There's no way to avoid a bunch of platform specific code, and it would be nice if LLVM had a solution that allowed LLDB to re-use some of LLVM's own platform specific code.


https://reviews.llvm.org/D48859





More information about the llvm-commits mailing list