[PATCH] D47188: Intel SVML calling conventions

[Hideki Saito via Phabricator via llvm-commits]

hsaito added inline comments.
Herald added a subscriber: dexonsmith.


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:55
+  std::string FullName = FnName;
+  return IsFast ? FullName : FullName + "_ha";
+}
----------------
I have a problem for the use of "_ha" interface in the non-fast case. Unless the compiler is in a reasonably relaxed mode, I'd like vector computation and scalar computation to be bitwise-identical. "_ha" interface of SVML doesn't produce the bitwise identical result as scalar call. I'm sure there is a room for using "_ha" interface, but we need to carefully design how to enable it. By simply using SVML, I don't think the programmer gave the compiler a license to deviate from bitwise identical results. I may be too much of a paranoid about it, but there is a fair number of people who ask for bitwise identity.


https://reviews.llvm.org/D47188