[PATCH] D48209: [MCA] Add -summary-view option

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D48209#1133459, @andreadb wrote:

> In https://reviews.llvm.org/D48209#1133445, @courbet wrote:
>
> > In https://reviews.llvm.org/D48209#1133429, @andreadb wrote:
> >
> > > Not sure what other reviewers think about this.
> > >  However, my opinion is that the summary view should never be optional in llvm-mca.
> > >  It is only a few lines, and it gives a nice overview of the run.
> >
> >
> > I mostly agree, but it does not hurt to have the option to disable it if you don;t want it to appear. Given that the patch is very small, I would be in favor of submitting.
>
>
> Out of curiosity: what's the motivating use case for this change? Is it just for testing purposes (i.e. https://reviews.llvm.org/D48190)?


I personally have no need to hide that view in any *normal* case,
so at this moment - yes, just for testing purposes.
It just feels a bit inconsistent for no reason, everything else is toggleable :)


Repository:
  rL LLVM

https://reviews.llvm.org/D48209