[PATCH] D48209: [MCA] Add -summary-view option

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 04:30:24 PDT 2018


andreadb added a comment.

In https://reviews.llvm.org/D48209#1133445, @courbet wrote:

> In https://reviews.llvm.org/D48209#1133429, @andreadb wrote:
>
> > Not sure what other reviewers think about this.
> >  However, my opinion is that the summary view should never be optional in llvm-mca.
> >  It is only a few lines, and it gives a nice overview of the run.
>
>
> I mostly agree, but it does not hurt to have the option to disable it if you don;t want it to appear. Given that the patch is very small, I would be in favor of submitting.


Out of curiosity: what's the motivating use case for this change? Is it just for testing purposes (i.e. https://reviews.llvm.org/D48190)?


Repository:
  rL LLVM

https://reviews.llvm.org/D48209





More information about the llvm-commits mailing list