[PATCH] D48209: [MCA] Add -summary-view option

[Greg Bedwell via Phabricator via llvm-commits]

gbedwell added inline comments.


================
Comment at: test/tools/llvm-mca/X86/option-all-views-1.s:4
 # RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=btver2 -all-views=true  < %s | FileCheck %s -check-prefix=ALL -check-prefix=DEFAULTREPORT -check-prefix=FULLREPORT
 # RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=btver2 -all-views=false < %s | FileCheck %s -check-prefix=ALL -check-prefix=NOREPORT
 # RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=btver2                  < %s | FileCheck %s -check-prefix=ALL -check-prefix=DEFAULTREPORT
----------------
Seems like there is no need for the ALL prefix now as there is no common output to all of them.  This highlights a few issues in the update script that I'll look at fixing.  I would've preferred if it had previously warned that the NOREPORT prefix was redundant and that now both the NOREPORT and ALL prefixes are redundant.  Lit does spot this:

```error: no check strings found with prefixes 'ALL:', 'NOREPORT:'```
so I'll make sure the update script does too.

To get the test to pass, we'll need to add "-allow-empty" to that FileCheck command line, and then to make it useful, manually add:

```# NOREPORT-NOT: {{.}}```
to the test file.  The update script will leave any prefixes where it detects a -NOT alone on the assumption that you're checking for something it doesn't understand.


Repository:
  rL LLVM

https://reviews.llvm.org/D48209