[PATCH] D47208: [profile] Support profiling runtime on Fuchsia

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:10
 
-#if defined(__linux__) || defined(__FreeBSD__) || \
+#if defined(__linux__) || defined(__FreeBSD__) || defined(__Fuchsia__) || \
     (defined(__sun__) && defined(__svr4__))
----------------
phosek wrote:
> davidxl wrote:
> > vsk wrote:
> > > phosek wrote:
> > > > This file seems more related to the file format and linker support than platform. Would there be any objections against renaming `InstrProfilingPlatformLinux.c` to `InstrProfilingPlatformELF.c` and similarly `InstrProfilingPlatformDarwin.c` to `InstrProfilingPlatformMachO.c`?
> > > No objection here.
> > if you want to do this, please do it in a separate patch.
> D47212
There are no other MachO platforms other than Darwin anyway.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D47208