[PATCH] D47208: [profile] Support profiling runtime on Fuchsia

[David Li via Phabricator via llvm-commits]

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c:102
+
+  lprofSetupValueProfiler();
+
----------------
phosek wrote:
> davidxl wrote:
> > Probably don't need this. In fact, buffer API does not yet support value profile data dump, so value profiling can be turned off by default for Fusia.
> Is it just the matter of extending the buffer API implementation? I'd be happy to look into it (in a separate patch).
The problem is builds that only depend on buffer APIs can not depend on libc (for dynamic memory allocation).  Value profiling dump requires dynamically allocated memory.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D47208