[PATCH] D47208: [profile] Support profiling runtime on Fuchsia

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c:102
+
+  lprofSetupValueProfiler();
+
----------------
davidxl wrote:
> Probably don't need this. In fact, buffer API does not yet support value profile data dump, so value profiling can be turned off by default for Fusia.
Is it just the matter of extending the buffer API implementation? I'd be happy to look into it (in a separate patch).


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:10
 
-#if defined(__linux__) || defined(__FreeBSD__) || \
+#if defined(__linux__) || defined(__FreeBSD__) || defined(__Fuchsia__) || \
     (defined(__sun__) && defined(__svr4__))
----------------
davidxl wrote:
> vsk wrote:
> > phosek wrote:
> > > This file seems more related to the file format and linker support than platform. Would there be any objections against renaming `InstrProfilingPlatformLinux.c` to `InstrProfilingPlatformELF.c` and similarly `InstrProfilingPlatformDarwin.c` to `InstrProfilingPlatformMachO.c`?
> > No objection here.
> if you want to do this, please do it in a separate patch.
D47212


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D47208