[PATCH] D46356: [TableGen] Emit a fatal error on inconsistencies in resource units vs cycles.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 06:33:27 PDT 2018


RKSimon added a comment.

Can you pull out the SLM / BW fixes into their own commits please?



================
Comment at: lib/Target/X86/X86SchedBroadwell.td:1657
   let NumMicroOps = 4;
-  let ResourceCycles = [1,2,1,7];
+  let ResourceCycles = [1,2,1];
 }
----------------
This fix can be committed now in its own commit.


================
Comment at: lib/Target/X86/X86ScheduleSLM.td:393
   let NumMicroOps = 1;
-  let ResourceCycles = [1,70];
+  let ResourceCycles = [1,1,70];
 }
----------------
This fix (and the llvm-mca test change) can be committed in its own commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D46356





More information about the llvm-commits mailing list