[PATCH] D45244: Add missing vtable anchors
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 11 13:46:13 PDT 2018
I meant that lib/LTO/LLVMBuild.txt should include "ExecutionEngine" in its
required_libraries. I wouldn't expect any changes would be needed to
tools/lto/* or tools/llvm-lto/*.
On Wed, Apr 11, 2018 at 1:41 PM Weiming Zhao via Phabricator <
reviews at reviews.llvm.org> wrote:
> weimingz added a comment.
>
> In https://reviews.llvm.org/D45244#1064649, @dblaikie wrote:
>
> > That sort of surprises me - if that were the case, there would be no
> point
> > having LLVMBuild.txt files in any libraries, I would think?
>
>
> Hi David,
>
> Do you mean changes like:
> diff --git a/lib/LTO/CMakeLists.txt b/lib/LTO/CMakeLists.txt
>
> - a/lib/LTO/CMakeLists.txt
>
> +++ b/lib/LTO/CMakeLists.txt
> @@ -13,4 +13,5 @@ add_llvm_library(LLVMLTO
>
> DEPENDS
> intrinsics_gen
> llvm_vcsrevision_h
>
> + LLVMLTO
> )
> In this case, I think the dependency rule won't affect the build of
> libLLVMLTO.a. I tried and it didn't work. Or maybe I misunderstood what you
> meant?
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D45244
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180411/ce84c88d/attachment.html>
More information about the llvm-commits
mailing list