[PATCH] D45244: Add missing vtable anchors

Weiming Zhao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 11 13:41:53 PDT 2018


weimingz added a comment.

In https://reviews.llvm.org/D45244#1064649, @dblaikie wrote:

> That sort of surprises me - if that were the case, there would be no point
>  having LLVMBuild.txt files in any libraries, I would think?


Hi David,

Do you mean changes like:
diff --git a/lib/LTO/CMakeLists.txt b/lib/LTO/CMakeLists.txt

- a/lib/LTO/CMakeLists.txt

+++ b/lib/LTO/CMakeLists.txt
@@ -13,4 +13,5 @@ add_llvm_library(LLVMLTO

  DEPENDS
  intrinsics_gen
  llvm_vcsrevision_h

+  LLVMLTO
 )
In this case, I think the dependency rule won't affect the build of libLLVMLTO.a. I tried and it didn't work. Or maybe I misunderstood what you meant?


Repository:
  rL LLVM

https://reviews.llvm.org/D45244





More information about the llvm-commits mailing list