<div dir="ltr">I meant that lib/LTO/LLVMBuild.txt should include "ExecutionEngine" in its required_libraries. I wouldn't expect any changes would be needed to tools/lto/* or tools/llvm-lto/*.<br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Apr 11, 2018 at 1:41 PM Weiming Zhao via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">weimingz added a comment.<br>
<br>
In <a href="https://reviews.llvm.org/D45244#1064649" rel="noreferrer" target="_blank">https://reviews.llvm.org/D45244#1064649</a>, @dblaikie wrote:<br>
<br>
> That sort of surprises me - if that were the case, there would be no point<br>
>  having LLVMBuild.txt files in any libraries, I would think?<br>
<br>
<br>
Hi David,<br>
<br>
Do you mean changes like:<br>
diff --git a/lib/LTO/CMakeLists.txt b/lib/LTO/CMakeLists.txt<br>
<br>
- a/lib/LTO/CMakeLists.txt<br>
<br>
+++ b/lib/LTO/CMakeLists.txt<br>
@@ -13,4 +13,5 @@ add_llvm_library(LLVMLTO<br>
<br>
  DEPENDS<br>
  intrinsics_gen<br>
  llvm_vcsrevision_h<br>
<br>
+  LLVMLTO<br>
 )<br>
In this case, I think the dependency rule won't affect the build of libLLVMLTO.a. I tried and it didn't work. Or maybe I misunderstood what you meant?<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D45244" rel="noreferrer" target="_blank">https://reviews.llvm.org/D45244</a><br>
<br>
<br>
<br>
</blockquote></div>