[PATCH] D44404: [ASan] Report proper ASan error on allocator failures instead of CHECK(0)-ing

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 22 14:15:09 PDT 2018


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

Looks fine.



================
Comment at: lib/asan/asan_allocator.cc:600
       AllocatorCache *ac = GetAllocatorCache(ms);
-      quarantine.Put(GetQuarantineCache(ms), QuarantineCallback(ac), m,
-                           m->UsedSize());
+      quarantine.Put(GetQuarantineCache(ms), QuarantineCallback(ac, stack), m,
+                     m->UsedSize());
----------------
Please double check that "stack" is not used after it is deallocated.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44404





More information about the llvm-commits mailing list