[PATCH] D44404: [ASan] Report proper ASan error on allocator failures instead of CHECK(0)-ing

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 11:10:04 PDT 2018


alekseyshl updated this revision to Diff 139334.
alekseyshl added a comment.

- Do not call SetAllocatorOutOfMemory in new interceptors

SetAllocatorOutOfMemory should not be called in new interceptors,
it should be called when OOM is actually detected and asan allocator
takes care of that.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44404

Files:
  lib/asan/asan_allocator.cc
  lib/asan/asan_errors.cc
  lib/asan/asan_errors.h
  lib/asan/asan_new_delete.cc
  lib/asan/asan_report.cc
  lib/asan/asan_report.h
  lib/sanitizer_common/sanitizer_allocator.cc
  lib/sanitizer_common/sanitizer_allocator.h
  test/asan/TestCases/Linux/aligned_alloc-alignment.cc
  test/asan/TestCases/Linux/allocator_oom_test.cc
  test/asan/TestCases/Linux/pvalloc-overflow.cc
  test/asan/TestCases/Posix/posix_memalign-alignment.cc
  test/asan/TestCases/Windows/oom.cc
  test/asan/TestCases/allocator_returns_null.cc
  test/asan/TestCases/calloc-overflow.cc
  test/asan/TestCases/malloc-size-too-big.cc
  test/sanitizer_common/TestCases/Linux/soft_rss_limit_mb_test.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44404.139334.patch
Type: text/x-patch
Size: 30522 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180321/c6bf03a8/attachment.bin>


More information about the llvm-commits mailing list