[PATCH] D44404: [ASan] Report proper ASan error on allocator failures instead of CHECK(0)-ing

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl marked an inline comment as done.
alekseyshl added inline comments.


================
Comment at: lib/asan/asan_allocator.cc:600
       AllocatorCache *ac = GetAllocatorCache(ms);
-      quarantine.Put(GetQuarantineCache(ms), QuarantineCallback(ac), m,
-                           m->UsedSize());
+      quarantine.Put(GetQuarantineCache(ms), QuarantineCallback(ac, stack), m,
+                     m->UsedSize());
----------------
eugenis wrote:
> Please double check that "stack" is not used after it is deallocated.
Yep, QuarantineCallback instance is not stored anywhere, it is used in the context of Put() call only.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44404