[PATCH] D44736: DWARFVerifier: verify debug_names abbreviation table

[Madhur Amilkanthwar via llvm-commits]

Does this patch covers all planned checks or there are any left which will
come later?

On Thu, Mar 22, 2018, 5:22 PM Jonas Devlieghere via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> JDevlieghere accepted this revision.
> JDevlieghere added a comment.
> This revision is now accepted and ready to land.
>
> LGTM!
>
>
>
> ================
> Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:970
> +
> +  if (AttrEnc.Index == DW_IDX_type_hash) {
> +    if (AttrEnc.Form != dwarf::DW_FORM_data8) {
> ----------------
> nit: can we move this above the table initialization?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D44736
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180322/40d6dd46/attachment.html>