[PATCH] D44736: DWARFVerifier: verify debug_names abbreviation table

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 22 04:51:55 PDT 2018


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:970
+
+  if (AttrEnc.Index == DW_IDX_type_hash) {
+    if (AttrEnc.Form != dwarf::DW_FORM_data8) {
----------------
nit: can we move this above the table initialization? 


Repository:
  rL LLVM

https://reviews.llvm.org/D44736





More information about the llvm-commits mailing list