<div dir="auto">Does this patch covers all planned checks or there are any left which will come later?</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Mar 22, 2018, 5:22 PM Jonas Devlieghere via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">JDevlieghere accepted this revision.<br>
JDevlieghere added a comment.<br>
This revision is now accepted and ready to land.<br>
<br>
LGTM!<br>
<br>
<br>
<br>
================<br>
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:970<br>
+<br>
+  if (AttrEnc.Index == DW_IDX_type_hash) {<br>
+    if (AttrEnc.Form != dwarf::DW_FORM_data8) {<br>
----------------<br>
nit: can we move this above the table initialization?<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D44736" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D44736</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>