[PATCH] D44404: [ASan] Report proper ASan error on allocator failures instead of CHECK(0)-ing

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 12:10:12 PDT 2018


alekseyshl marked an inline comment as done.
alekseyshl added inline comments.


================
Comment at: lib/asan/asan_errors.h:26
   explicit ErrorBase(u32 tid_) : tid(tid_) {}
+  ErrorBase(u32 tid_, int initial_score, const char *reason) : tid(tid_) {
+    scariness.Clear();
----------------
eugenis wrote:
> Please update existing error objects with this constructor, too. Either before or after this patch.
That was the plan, to update the rest in a separate patch, just did not want to add unrelated changes here.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44404





More information about the llvm-commits mailing list