[PATCH] D44682: [ELF] Fix X86 & X86_64 PLT retpoline padding

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 16:48:39 PDT 2018


espindola added a comment.

In https://reviews.llvm.org/D44682#1043455, @ruiu wrote:

> Instead of doing this, we should fill executable segments with trap instructions even if linker script is in use, shouldn't we?


The issue with linker scripts is that they force SingleRoRx. This causes text and data to be mixed.

These tests should probably use --no-rosegment instead of linkerscripts.


https://reviews.llvm.org/D44682





More information about the llvm-commits mailing list