[PATCH] D44682: [ELF] Fix X86 & X86_64 PLT retpoline padding

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

In https://reviews.llvm.org/D44682#1043962, @espindola wrote:

> In https://reviews.llvm.org/D44682#1043455, @ruiu wrote:
>
> > Instead of doing this, we should fill executable segments with trap instructions even if linker script is in use, shouldn't we?
>
>
> The issue with linker scripts is that they force SingleRoRx. This causes text and data to be mixed.


Hm, then what is the point of this change? We could fill unused .plt bytes with trap instructions, but you still have plenty of bytes that are executable if all data is executable.


https://reviews.llvm.org/D44682