[PATCH] D44682: [ELF] Fix X86 & X86_64 PLT retpoline padding

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Instead of doing this, we should fill executable segments with trap instructions even if linker script is in use, shouldn't we?



================
Comment at: ELF/Arch/X86.cpp:184
     };
+    assert(sizeof(V) == PltHeaderSize);
     memcpy(Buf, V, sizeof(V));
----------------
I don't like to sprinkle too many asserts in code.


https://reviews.llvm.org/D44682