[llvm] r326710 - Fuzzer: remove temporary files after we're done with them.

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 12 06:39:01 PDT 2018


> Marking them unsupported on Windows doesn't sound ideal either since
> the tests work fine on Windows, it's just removing the temp files that
> doesn’t.

I think a test leaving 8GB of stray data isn’t working no matter where it exists, and there’s no guarantee lit would be any more capable of deleting these files. Something in Windows (or maybe just that bot) is fundamentally broken here and shouldn’t be coddled.

I’m OK with reverting while we decide a plan, but not OK with leaving it as the status-quo. There’s a good chance this is wasting petabytes of data globally, which is not reasonable for such a trivial test.

Perhaps we could add a —dont-care option to not so that failure doesn’t nuke the whole test?

Cheers.

Tim.


More information about the llvm-commits mailing list