[llvm] r326710 - Fuzzer: remove temporary files after we're done with them.

[Nico Weber via llvm-commits]

On Mon, Mar 12, 2018 at 9:39 AM, Tim Northover <tnorthover at apple.com> wrote:

> > Marking them unsupported on Windows doesn't sound ideal either since
> > the tests work fine on Windows, it's just removing the temp files that
> > doesn’t.
>
> I think a test leaving 8GB of stray data isn’t working no matter where it
> exists, and there’s no guarantee lit would be any more capable of deleting
> these files. Something in Windows (or maybe just that bot)


It's flakily failing on several Windows bots both on the LLVM and Chromium
waterfalls, so it's not bot-specific.


> is fundamentally broken here and shouldn’t be coddled.
>

On Windows, a file can't be deleted if something still holds a reference to
it. This is probably somehow related to that.


> I’m OK with reverting while we decide a plan, but not OK with leaving it
> as the status-quo. There’s a good chance this is wasting petabytes of data
> globally, which is not reasonable for such a trivial test.
>

If the test creates 8GB of data, that seems kind of inefficient even if
it's deleted right after. Igor, is it possible to make these tests use 2-4
orders of magnitude less data? If not, maybe the tests cost more than they
help and we should just delete them?


> Perhaps we could add a —dont-care option to not so that failure doesn’t
> nuke the whole test?
>

Cleaning up after tests seems like something lit should do; it feels
inefficient if we need to do this manually for every test.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180312/4a72c3d3/attachment.html>