[llvm] r326710 - Fuzzer: remove temporary files after we're done with them.

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 12 06:27:45 PDT 2018


On Fri, Mar 9, 2018 at 7:32 PM, Tim Northover <tnorthover at apple.com> wrote:
> On 9 Mar 2018, at 15:45, Tim Northover via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> So in the absence of any actual Windows experience, I’ll try adding “-f” as a pot-shot.
>
> Nope. No luck there. I’m very tempted to mark it unsupported on Windows hosts, unless we can identify a particular configuration issue on that bot. Creating a file and then removing it seems like a fundamentally sane sequence of operations to me.

I've reverted in r327266 to unblock us for now.

Marking them unsupported on Windows doesn't sound ideal either since
the tests work fine on Windows, it's just removing the temp files that
doesn't.

Temporary files like this are created all over the place. I suppose
these are just extra bad because they're large?

One could argue that lit should be cleaning up these temp files after
itself. It should have the information since it's the one creating all
the Output/ dirs. Perhaps it should be deleting those by default
unless some flag is passed?


More information about the llvm-commits mailing list