[PATCH] D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAddressRange.h:51
 
-  void dump(raw_ostream &OS, uint32_t AddressSize) const;
+  void dump(raw_ostream &OS, uint32_t AddressSize, bool Brackets = true) const;
 };
----------------
Maybe this is an option we can store in the `DIDumpOptions`? 


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h:46
+    /// The offset at which the entry is located in the section.
+    uint32_t Offset;
+    /// The DWARF encoding (DW_RLE_*).
----------------
Can these members be const?


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:170
+                           DWARFDebugRnglists::RangeListEntry Entry,
+                           uint8_t AddrSize, bool Verbose) {
+  if (Verbose) {
----------------
Personally I'd prefer reading the verbose flag from the `DIDumpOptions`. 


https://reviews.llvm.org/D43366