[PATCH] D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h:56
+
+    RangeListEntry() = delete;
+
----------------
I think this is unnecessary - since there's a non-default ctor, so the default ctor wouldn't be provided by default?


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h:58-61
+    RangeListEntry(uint32_t Offset, uint8_t EntryKind, uint64_t Value0 = 0,
+                   uint64_t Value1 = 0)
+        : Offset(Offset), EntryKind(EntryKind), Value0(Value0), Value1(Value1) {
+    }
----------------
maybe this ctor could be skipped and {} init could be used?


================
Comment at: test/tools/llvm-dwarfdump/X86/debug_rnglists.s:19-24
+# VERBOSE-NEXT: 0x0000000c: [DW_RLE_start_end]: [0x0000000000000010, 0x0000000000000020)
+# VERBOSE-NEXT: 0x0000001d: [DW_RLE_start_length]: 0x0000000000000025, 0x0000000000000080
+# VERBOSE-SAME: => [0x0000000000000025, 0x00000000000000a5)
+# VERBOSE-NEXT: 0x00000028: [DW_RLE_end_of_list]
+# VERBOSE-NEXT: 0x00000029: [DW_RLE_start_end]: [0x0000000000000100, 0x0000000000000200)
+# VERBOSE-NEXT: 0x0000003a: [DW_RLE_end_of_list]
----------------
Probably worth making the prefix indentation consistent (ie: padding the [DW_RLE_...] with spaces on the right, so the DW_RLE_s line up, and the range lines up on the RHS too?


================
Comment at: test/tools/llvm-dwarfdump/X86/debug_rnglists.s:26
+
+# DEFAULT-NEXT: Range List Header: length = 0x0000002b, version = 0x0005, addr_size = 0x04, seg_size = 0x00, offset_entry_count = 0x00000002
+
----------------
Maybe "TERSE" rather than "DEFAULT" to make it easy to see it's the comparison between verbose and not verbose?


https://reviews.llvm.org/D43366