[PATCH] D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h:51
+    /// a start and end address or a start address and a length. Others are
+    /// single value base addresses or end-of-list with no values.
+    uint64_t Value0;
----------------
jhenderson wrote:
> Perhaps worth mentioning that in the other cases the Value(s) are undefined.
Gave default parameters to the constructor for the less-than-2-value cases.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:46
+  if (HeaderData.Length == 0xffffffffu)
+    return make_error<StringError>("DWARF64 is not supported in .dbg_rnglists",
+                                   inconvertibleErrorCode());
----------------
jhenderson wrote:
> .dbg_rnglists -> .debug_rnglists
> 
> Let's not abbreviate things in error messages that look like section names! Also, use the createError() method, used elsewhere in this function, and it would be good if this error provides the offset of the offending table (again, see the use of createError elsewhere).
> 
> Also, test case for this error?
createError() does not take just a string, but with the added table offset it works.


https://reviews.llvm.org/D43366