[PATCH] D42550: Put the header in the first PT_LOAD even if that PT_LOAD has a LMAExpr

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 06:35:02 PST 2018


emaste added inline comments.


================
Comment at: ELF/Writer.h:50
+  // linker script: AT(addr).
+  bool ASectionHasLMA = false;
+
----------------
ruiu wrote:
> I would remove `A` because it looks like it's A in A, B, C, .... and it's true even if two or more sections has a LMA.
I think 'a section has LMA' is grammatically fine even if two or more sections have an LMA, but I see how it could be unclear; what about explicit 'AnySectionHasLMA'?


https://reviews.llvm.org/D42550





More information about the llvm-commits mailing list