[PATCH] D42550: Put the header in the first PT_LOAD even if that PT_LOAD has a LMAExpr

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 28 19:22:03 PST 2018


Ed Maste via Phabricator <reviews at reviews.llvm.org> writes:

> emaste added inline comments.
>
>
> ================
> Comment at: ELF/Writer.h:50
> +  // linker script: AT(addr).
> +  bool ASectionHasLMA = false;
> +
> ----------------
> ruiu wrote:
>> I would remove `A` because it looks like it's A in A, B, C, .... and it's true even if two or more sections has a LMA.
> I think 'a section has LMA' is grammatically fine even if two or more sections have an LMA, but I see how it could be unclear; what about explicit 'AnySectionHasLMA'?

So, there is always only one section with an explicit LMA in each
program header. I will update the comment to say that and commit. Let me
know if you would still prefer another name.

Cheres,
Rafael


More information about the llvm-commits mailing list