[PATCH] D42550: Put the header in the first PT_LOAD even if that PT_LOAD has a LMAExpr

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 12:49:09 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Writer.h:50
+  // linker script: AT(addr).
+  bool ASectionHasLMA = false;
+
----------------
I would remove `A` because it looks like it's A in A, B, C, .... and it's true even if two or more sections has a LMA.


https://reviews.llvm.org/D42550





More information about the llvm-commits mailing list