[PATCH] D42204: Make the bloom filter a bit larger.

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama <ruiu at google.com> writes:

> On Wed, Jan 24, 2018 at 9:54 AM, Rafael Avila de Espindola <
> rafael.espindola at gmail.com> wrote:
>
>> Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
>>
>> > ruiu created this revision.
>> > ruiu added reviewers: grimar, rafael.
>> > Herald added a subscriber: emaste.
>> >
>> > I created https://reviews.llvm.org/D42202 to see how large the bloom
>> > filter should be. With that patch, I tested various bloom filter sizes
>> > with the following commands:
>> >
>> >   $ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_LLD=true \
>> >     -DLLVM_ENABLE_PROJECTS='clang;lld' -DBUILD_SHARED_LIBS=ON \
>> >     -DCMAKE_SHARED_LINKER_FLAGS=-Wl,-bloom-filter-bits=<some integer> \
>> >     ../llvm-project/llvm
>> >   $ rm -f $(find . -name \*.so.7.0.0svn)
>> >   $ ninja lld
>> >   $ LD_BIND_NOW=1 perf stat bin/ld.lld
>> >
>> > Here is the result:
>> >
>> >   -bloom-filter-bits=8   0.220351609 seconds
>> >   -bloom-filter-bits=10  0.217146597 seconds
>> >   -bloom-filter-bits=12  0.206870826 seconds
>> >   -bloom-filter-bits=16  0.209456312 seconds
>> >   -bloom-filter-bits=32  0.195092075 seconds
>>
>> Looking at a plot of the data it is not clear that the returns are
>> diminishing that much.
>>
>
> Maybe you should change the Y axis to start from zero.

Attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: test.svg
Type: image/svg+xml
Size: 9565 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180124/e2a4acc2/attachment.svg>
-------------- next part --------------

Cheers,
Rafael