[PATCH] D42204: Make the bloom filter a bit larger.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 10:21:39 PST 2018


On Wed, Jan 24, 2018 at 9:54 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
>
> > ruiu created this revision.
> > ruiu added reviewers: grimar, rafael.
> > Herald added a subscriber: emaste.
> >
> > I created https://reviews.llvm.org/D42202 to see how large the bloom
> > filter should be. With that patch, I tested various bloom filter sizes
> > with the following commands:
> >
> >   $ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_LLD=true \
> >     -DLLVM_ENABLE_PROJECTS='clang;lld' -DBUILD_SHARED_LIBS=ON \
> >     -DCMAKE_SHARED_LINKER_FLAGS=-Wl,-bloom-filter-bits=<some integer> \
> >     ../llvm-project/llvm
> >   $ rm -f $(find . -name \*.so.7.0.0svn)
> >   $ ninja lld
> >   $ LD_BIND_NOW=1 perf stat bin/ld.lld
> >
> > Here is the result:
> >
> >   -bloom-filter-bits=8   0.220351609 seconds
> >   -bloom-filter-bits=10  0.217146597 seconds
> >   -bloom-filter-bits=12  0.206870826 seconds
> >   -bloom-filter-bits=16  0.209456312 seconds
> >   -bloom-filter-bits=32  0.195092075 seconds
>
> Looking at a plot of the data it is not clear that the returns are
> diminishing that much.
>

Maybe you should change the Y axis to start from zero.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180124/cfc820f8/attachment.html>


More information about the llvm-commits mailing list