[PATCH] D40979: [DWARF] Allow duplication of tails with CFI instructions

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 15 09:47:43 PST 2018


thegameg added inline comments.


================
Comment at: lib/CodeGen/TailDuplicator.cpp:381
+    MCCFIInstruction NewCFI(CFI);
+    unsigned NewCFIIndex = PredBB->getParent()->addFrameInst(NewCFI);
+    BuildMI(*PredBB, PredBB->end(), PredBB->findDebugLoc(PredBB->begin()),
----------------
Do we actually need a copy? Does anything disallow us to share the CFIIndex (and reference the MCCFIInstruction more than once) within the same function?


Repository:
  rL LLVM

https://reviews.llvm.org/D40979





More information about the llvm-commits mailing list