[PATCH] D40979: [DWARF] Allow duplication of tails with CFI instructions

[Djordje Kovacevic via Phabricator via llvm-commits]

djokov added inline comments.


================
Comment at: lib/CodeGen/TailDuplicator.cpp:381
+    MCCFIInstruction NewCFI(CFI);
+    unsigned NewCFIIndex = PredBB->getParent()->addFrameInst(NewCFI);
+    BuildMI(*PredBB, PredBB->end(), PredBB->findDebugLoc(PredBB->begin()),
----------------
thegameg wrote:
> Do we actually need a copy? Does anything disallow us to share the CFIIndex (and reference the MCCFIInstruction more than once) within the same function?
According to tests, we don't need a copy. It works fine with referencing the existing MCCFIInstruction.


Repository:
  rL LLVM

https://reviews.llvm.org/D40979