[PATCH] D40979: [DWARF] Allow duplication of tails with CFI instructions

[Djordje Kovacevic via Phabricator via llvm-commits]

djokov marked 2 inline comments as done.
djokov added a comment.





================
Comment at: lib/CodeGen/TailDuplicator.cpp:379-411
+  switch (CFI.getOperation()) {
+  default: {
+    llvm_unreachable("Duplicating unsupported CFI instruction.");
+    return;
+  }
+  case MCCFIInstruction::OpDefCfaRegister: {
+    NewCFIIndex = MF->addFrameInst(
----------------
MatzeB wrote:
> Why not implement a copy constructor for MCCFIInstruction instead?
Turns out default copy constructor for MCCFIInstruction already does what is needed.


Repository:
  rL LLVM

https://reviews.llvm.org/D40979