[PATCH] D40979: [DWARF] Allow duplication of tails with CFI instructions

Mon Jan 15 09:23:35 PST 2018

djokov updated this revision to Diff 129872.
djokov added a comment.

In https://reviews.llvm.org/D40979#969990, @MatzeB wrote:

> I would advise to keep the `NotDuplicable` instruction attribute for now as long as our code cannot handle it. But moving the duplication logic into MachineInstr/MCCFIInstruction is a good idea anyway.

I agree. I meant to change that attribute only after fixing generateCompactUnwindEncoding in ARM, AArch64 and x86 backends to fallback to DWARF.

Anyway, I updated this patch. CFI instructions are still 'NotDuplicable', and they are duplicated by using default copy constructor of MCCFIInstruction.

Repository:
  rL LLVM

https://reviews.llvm.org/D40979

Files:
  lib/CodeGen/TailDuplicator.cpp
  test/CodeGen/AArch64/taildup-cfi.ll
  test/CodeGen/X86/avx512-mask-op.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40979.129872.patch
Type: text/x-patch
Size: 7270 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180115/8fc72bad/attachment.bin>