[PATCH] D41926: [DWARFv5] CodeGen support for MD5 checksum

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:277
+      memcpy(CKMem, Checksum.data(), Checksum.size());
+      MD5Checksum = reinterpret_cast<MD5::MD5Result *>(CKMem);
+    }
----------------
aprantl wrote:
> do we need error handling here or is it okay to silently drop malformed input?
It would have to be malformed metadata, which is how likely?  I should point out that `fromHex()` will actually assert if the string has non-hex digits in it, so there's a limit to how conscientious it's worth being here.


https://reviews.llvm.org/D41926