[PATCH] D41926: [DWARFv5] CodeGen support for MD5 checksum

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In https://reviews.llvm.org/D41926#972886, @aprantl wrote:

> This was not immediately obvious to me: Why can we now have empty DIFiles?
>  LGTM otherwise.


The possibly empty DIFiles were previously accommodated by various getFilename() methods, for example in DebugInfoMetadata.h:

  StringRef DIScope::getFilename() const {
    if (auto *F = getFile())
      return F->getFilename();
    return "";
  }

I am also unclear why they can happen, but I found out the hard way that they do.  Possibly only in tests, because LLParser is willing to allow many attributes to be omitted, but I got crashes before I made the same accommodation.


https://reviews.llvm.org/D41926