[PATCH] D41926: [DWARFv5] CodeGen support for MD5 checksum

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:277
+      memcpy(CKMem, Checksum.data(), Checksum.size());
+      MD5Checksum = reinterpret_cast<MD5::MD5Result *>(CKMem);
+    }
----------------
probinson wrote:
> aprantl wrote:
> > do we need error handling here or is it okay to silently drop malformed input?
> It would have to be malformed metadata, which is how likely?  I should point out that `fromHex()` will actually assert if the string has non-hex digits in it, so there's a limit to how conscientious it's worth being here.
I think I'm confused by the fact that we are converting a hex string in AsmPrinter. I would have expected that conversion to happen in the LLVM IR parser. From what sources can we get a Hex *string* here?


https://reviews.llvm.org/D41926