[PATCH] D41926: [DWARFv5] CodeGen support for MD5 checksum

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

This was not immediately obvious to me: Why can we now have empty DIFiles?
LGTM otherwise.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:277
+      memcpy(CKMem, Checksum.data(), Checksum.size());
+      MD5Checksum = reinterpret_cast<MD5::MD5Result *>(CKMem);
+    }
----------------
do we need error handling here or is it okay to silently drop malformed input?


https://reviews.llvm.org/D41926