[PATCH] D41659: Implementing missing trigonometric optimizations

ADIL ARUN DANGUI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 21:16:40 PST 2018

cs15btech11041 added a comment.

In https://reviews.llvm.org/D41659#965694, @fhahn wrote:

> Thanks for your patch!
> Usually it is easier to review smaller patches. Splitting it up into 4 patches for the 4 different cases you implemented would make it slightly easier to reason about the 4 unrelated transformation in isolation.

Yes. Thank you for the suggestions. I have updated the diff to incorporate the changes you suggested. And submitted different test case for each optimization in isolation. Hope it has made it easier to review the patch.



More information about the llvm-commits mailing list