[PATCH] D41659: Implementing missing trigonometric optimizations

ADIL ARUN DANGUI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 21:22:14 PST 2018

cs15btech11041 added a comment.

In https://reviews.llvm.org/D41659#965696, @rengolin wrote:

> This may need special guard with fast-math flags (precision, etc), no?

I have added FastMathFlagGuard Guard to the IRBuilder. And also copied the ffast-math flags of the division/multiplication instruction. To the new trigonometric/multiplication/division instruction inserted. As for precision, we are replacing two trigonometric functions with single equivalent trigonometric function with fast math flag guards. Also the type which we are specifying in  CreateCall is same as that of the division/multiplication instruction. Hence would have the same type and precision. Please let me know if I did not answer your question.



More information about the llvm-commits mailing list